I don't know that I have one favorite team. It'd be a toss-up between Team Plasma and Team Skull.
Team Plasma is interesting, what with the Seven Sages, Anthea and Concordia, the Shadow Triad, and of course N himself. While Ghetsis' ultimate plan was underwhelming, all his set-up for it was neat and seeing the team break into two rival factions in Black 2 and White 2 after N and Ghetsis' initial defeat in the original Black and White was cool. They definitely seem like the most compelling team from a lore perspective, though Ghetsis' dumb plan holds them back a bit.
Team Skull is goofy, fun, and I feel like a group of disaffected youths is a great, down to Earth idea for a team for the modern day. All of the other teams' grandiose plans are cool and all, but Team Skull are acting out in the face of a world they don't fit into and I really like that. They stick together trying to get by and it doesn't work out for them, but it sure is endearing. They're also led by Your Boy, Guzma, who is just fantastic. Their and Guzma's battle themes are great as well, and I really like their logo.
---
As far as the others are concerned:
- I like Team Rocket's simplicity of just being organized crime.
- I find Team Aqua's stated goals to be way more compelling than Team Magma's and absolutely love Archie's redesign in Omega Ruby/Alpha Sapphire.
- Team Magma pales in comparison to Team Aqua for me, so yeah. The only thing I find memorable about them is Courtney.
- Team Galactic is okay, but I'm fairly disinterested in the Sinnoh games in general so they've never really resonated with me. A universe without emotion is a fun idea at least.
- Lysandre does all the heavy lifting for Team Flare. I love Lysandre's motivation, but outside of him and Xerosic, they're really uninteresting. They also feel hampered down by the whole having to be rich and caring about making money to be a member. Malva could have been interesting if we got a Pok?mon Z that expounded more on her involvement, but as it stands it barely feels like her membership to the team should even count since it's addressed in just those few lines of dialogue.
- I haven't done the Rainbow Rocket content in Ultra Sun/Ultra Moon yet, so I don't know what I think of them, but from what I've gleaned by looking around, they don't strike me as that interesting off the bat and I feel like I'll still like their original version better.
- I can't speak to my thoughts on Team Yell since Sword and Shield aren't out yet, but to be honest my disinterest in Sword and Shield due to the inability to use every Pok?mon has me pretty much not really caring about most aspects of the games at the moment. I'm not entirely sure whether I'll be trying them or not. So yeah, not much to say here.